This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Support PNG images with non-8-bit depth #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for 1, 2, and 4 by decoding them into 8-bit. It adds "half support" for 16-bit, by extracting only the most significant byte. Adds unit tests with references images and color correctness checks.
gustavla
force-pushed
the
dev/png-bitdepth-support
branch
from
e733b79
to
f677c19
Compare
|
Nice! |
nickjong
approved these changes
Mar 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for 1, 2, and 4 by decoding them into 8-bit. It adds support for 16-bit, by extracting only the most significant byte. This incurs loss of precision, so not ideal, but I think probably better than not supporting it at all.
Adds unit tests with references images and color correctness checks.
Fixes #375, #77.