This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Gitignore cleanup #408
Merged
Gitignore cleanup #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 23, 2018 17:33
It causes lots of other random folders named `doc` to get excluded (including tracked files in src).
It's ignoring lots of valid things
There seem to be legit .mo files under deps that are being tracked.
There are legit tracked files in deps with extension .log.
They are ignoring some of the files we have committed into the repo.
We have tracked file src/external/xgboost/subtree/rabit/doc/python-requirements.txt
These generally never should be tracked.
Not sure if this was broken for anyone else, but I was getting:
```
In file included from /Users/zach/turicreate/src/unity/extensions/additional_sframe_utilities.cpp:15:
/Users/zach/turicreate/src/unity/extensions/additional_sframe_utilities.hpp:15:32: error: unknown type name 'image_type'; did you mean 'turi::image_type'?
void image_load_to_numpy(const image_type& img, size_t outptr_addr,
^~~~~~~~~~
turi::image_type
/Users/zach/turicreate/src/image/image_type.hpp:34:7: note: 'turi::image_type' declared here
class image_type {
^
1 error generated.
```
TobyRoseman
reviewed
Mar 31, 2018
|
@TobyRoseman Those Xcode files are meant to be gitignored (so I don't want to remove them from our gitignore). In theory projects should never require xcuserdata - they should use shared schemes instead if needed by CI systems for building. If we hit build issues I'll move these to a shared scheme (but otherwise I think they aren't relevant for us). |
TobyRoseman
approved these changes
Apr 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing lots of
.gitignorecontents that are actually shadowing intentionally tracked files in our repo.