Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Speed up build system #568

Merged
merged 14 commits into from May 2, 2018
Merged

Speed up build system #568

merged 14 commits into from May 2, 2018

Conversation

znation
Copy link
Contributor

@znation znation commented May 2, 2018

  • Make file copies go through rsync or copy_if_different when possible to avoid copying files that haven't changed.
  • Get full build working with ninja (which offers faster incremental build than make).
  • Remove Cython generated headers from output file list (these files don't actually seem to get generated, and nothing uses them; their existence causes the targets to get rebuilt, at least in ninja).
  • Add explicit output/byproducts for custom command(s) and external projects -- ninja is much pickier about these than make.

Zachary Nation added 13 commits April 27, 2018 00:36
@znation znation requested review from hoytak, ylow and nickjong May 2, 2018 08:29
ylow
ylow approved these changes May 2, 2018
View reviewed changes
Copy link
Collaborator

@ylow ylow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good. Great! +1 If it passes the build.

@znation znation merged commit e3b39fb into apple:master May 2, 2018
@znation znation deleted the ninja_build branch May 2, 2018 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ylow ylow ylow approved these changes

@hoytak hoytak Awaiting requested review from hoytak

@nickjong nickjong Awaiting requested review from nickjong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@znation @ylow