Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is Authenticator func a required? #63

Closed
dhdresser opened this issue Mar 24, 2017 · 2 comments · Fixed by #69
Closed

Why is Authenticator func a required? #63

dhdresser opened this issue Mar 24, 2017 · 2 comments · Fixed by #69
Assignees

Comments

@dhdresser
Copy link

Thanks for creating this great jwt middleware. Authenticator func is only called by LoginHandler(). If I want to write MyOwnLoginhandler() where I create my own claims and signing, I wouldn't need to set Authenticator then, but it is requirement set in the MiddlewareInit(). Right now I set Authenticator to return "", true.

Question... Would moving the check for Authenticator == nil in MiddlewareInit() to the LoginHandler() function be better suited? or maybe making this field optional? That way its not a hard requirement for those who wouldn't use LoginHandler.

@appleboy appleboy self-assigned this Apr 4, 2017
@appleboy
Copy link
Owner

appleboy commented Apr 4, 2017

@dhdresser Thanks for feedback. I will take it.

@appleboy
Copy link
Owner

appleboy commented Apr 4, 2017

@dhdresser bump to v2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants