Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get error logs from fail notifications. #213

Merged
merged 1 commit into from
Apr 10, 2017
Merged

feat: get error logs from fail notifications. #213

merged 1 commit into from
Apr 10, 2017

Conversation

appleboy
Copy link
Owner

fix #109

@codecov-io
Copy link

codecov-io commented Apr 10, 2017

Codecov Report

Merging #213 into master will decrease coverage by 0.01%.
The diff coverage is 87.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   96.25%   96.23%   -0.02%     
==========================================
  Files          13       13              
  Lines         907      930      +23     
==========================================
+ Hits          873      895      +22     
- Misses         26       27       +1     
  Partials        8        8
Impacted Files Coverage Δ
gorush/server.go 100% <100%> (ø) ⬆️
gorush/log.go 93% <70%> (+0.8%) ⬆️
gorush/notification.go 91.15% <92.59%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6997ea...31afec3. Read the comment docs.

@appleboy appleboy merged commit 0c9aad5 into master Apr 10, 2017
@appleboy appleboy deleted the errors branch April 10, 2017 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any way to get bad/invalid device tokens?
2 participants