Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(healthy): disable proxy in healthy check #457

Merged
merged 1 commit into from Jan 25, 2020
Merged

chore(healthy): disable proxy in healthy check #457

merged 1 commit into from Jan 25, 2020

Conversation

appleboy
Copy link
Owner

fixed: #456

Don’t use Go’s default HTTP client (in production)

ref: https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779

@appleboy appleboy added the bug label Jan 25, 2020
@codecov-io
Copy link

codecov-io commented Jan 25, 2020

Codecov Report

Merging #457 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   83.05%   83.05%           
=======================================
  Files          20       20           
  Lines        1393     1393           
=======================================
  Hits         1157     1157           
  Misses        188      188           
  Partials       48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a41ed...3a37733. Read the comment docs.

@appleboy appleboy merged commit 850509e into master Jan 25, 2020
@appleboy appleboy deleted the client branch January 25, 2020 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy interferes with healthcheck
2 participants