fix: Serialise nested protobuf structs correctly #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `fmt.Sprintf("%v", v)` to parse each value in the struct caused
nested structs to be serialised as strings, e.g.:
{"popup":"map[body:how are you? title:hey]","source":"poc.pushnotif"}
Using `structpb.AsMap` directly yields the correct serialisation:
{"popup":{"body":"how are you?","title":"hey"},"source":"poc.pushnotif"}
appleboy
approved these changes
May 5, 2022
|
LGTM, Thanks |
|
Hey @appleboy 👋 Again, thanks for considering the fix and merging it. Do you know when the next release will be? We found this issue when bumping our |
|
@jvallesm I will take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #671
When a notification request is received via the gRPC server, the
Datafield in the request is parsed from a*structpb.Structinto amap[string]interface{}. This map will eventually be serialised withjson.Marshal(here or here).Using
fmt.Sprintf("%v", v)to parse each value in the struct caused nested structs to be serialised as strings, e.g.:Using
structpb.AsMapdirectly yields the correct serialisation:You can see an example in this code snippet.