refactor: update FCM environment variables in Makefile and tests #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace `ANDROID_API_KEY` with `FCM_CREDENTIAL` in Makefile - Replace `ANDROID_TEST_TOKEN` with `FCM_TEST_TOKEN` in Makefile - Update environment variable `ANDROID_API_KEY` to `FCM_CREDENTIAL` in notification FCM tests - Update environment variable `ANDROID_TEST_TOKEN` to `FCM_TEST_TOKEN` in notification FCM tests - Update environment variable `ANDROID_TEST_TOKEN` to `FCM_TEST_TOKEN` in server tests Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
- Replace Android API key and test token with FCM credentials in GitHub Actions workflow - Refactor platform case handling in `CheckMessage` function - Remove test cases for empty token and excessive tokens in FCM message tests - Rename `To` field to `Topic` in FCM message tests Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
- Disable Android configuration in Huawei notification tests Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
- Remove the `TestCheckAndroidMessage` function from the FCM notification tests Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
- Change assertion in `TestSyncModeForDeviceGroupNotification` to expect 0 logs instead of 1 Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
- Change assertion to check for zero logs instead of one in `TestSyncModeForTopicNotification` Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANDROID_API_KEYwithFCM_CREDENTIALin MakefileANDROID_TEST_TOKENwithFCM_TEST_TOKENin MakefileANDROID_API_KEYtoFCM_CREDENTIALin notification FCM testsANDROID_TEST_TOKENtoFCM_TEST_TOKENin notification FCM testsANDROID_TEST_TOKENtoFCM_TEST_TOKENin server testsref #550