chore(storage): upgrade badger storage initialization #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade `github.com/dgraph-io/badger` from v3 to v4 - Remove `github.com/cespare/xxhash` v1 and keep v2 - Change `badger.New` function to accept `dbPath` instead of `config` - Replace `config` field with `dbPath` in `Storage` struct - Simplify mutex usage by embedding `sync.RWMutex` directly in `Storage` struct - Update test to initialize `badger` with an empty string instead of `config` - Increase loop iteration count in test from 10 to 100 - Update test assertion to expect `100` instead of `10` Signed-off-by: appleboy <appleboy.tw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/dgraph-io/badgerfrom v3 to v4github.com/cespare/xxhashv1 and keep v2badger.Newfunction to acceptdbPathinstead ofconfigconfigfield withdbPathinStoragestructsync.RWMutexdirectly inStoragestructbadgerwith an empty string instead ofconfig100instead of10