Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to support httpGeneratedImagesPath option like grunt-contrib-compass? #37

Closed
imsobear opened this issue Apr 21, 2014 · 9 comments

Comments

@imsobear
Copy link

Generally, we write compass sprite code like this in our src directory:

@import "icons/*.png";

.icon-hom {
  @include icons-sprite(home);
}

and it will be compiled to this:

.icon-home, .icon-tools, .icon-heart {
  background: url(../../../src/p/home/images/icons-s019adab402.png) no-repeat;
}

.icon-home {
  background-position:0 -465px;
}

Did you notice the background-url? It's relative path, but we also need an absolute path in production.

And with grunt-contrib-compass, It has a httpGeneratedImagesPath option to support this, you can get this option in here.

So, Is there a way to support httpGeneratedImagesPath option like grunt-contrib-compass?

Thanks for your reply!

@appleboy
Copy link
Owner

@imsobear

I will take it and feed back as soon as possible.

@imsobear
Copy link
Author

@appleboy

辛辛苦苦写这么多英语,然后发现你是台湾人哈,早知道用汉语了,2333...

@appleboy
Copy link
Owner

@imsobear

XDDD ... I know you are chinese.

@neekey
Copy link

neekey commented Aug 25, 2014

+1

appleboy added a commit that referenced this issue Oct 22, 2014
Allow passing of --generated-images-path to compass (fixes #37)
@noyobo
Copy link

noyobo commented Oct 22, 2014

看到这个更新, 眼泪掉下来 @imsobear, 学习了 compass 配置一天正准备实现这样的功能. .......

@appleboy
Copy link
Owner

@noyobo I will bump the next version. Please wait ..

@noyobo
Copy link

noyobo commented Oct 22, 2014

@appleboy
Learn from your, I made this repo last night, https://github.com/noyobo/gulp-compass-compile
Today saw the PR :(

@appleboy
Copy link
Owner

@noyobo XDDD

@neekey
Copy link

neekey commented Oct 22, 2014

Actually at last I create this gulp-for-compass by myself, which is basically modified from grunt-contrib-compass, which means you can have every options grunt-contrib-compass has to use with gulp-for-compass

chaffeqa added a commit to sportstech/gulp-compass that referenced this issue Nov 17, 2014
* 'master' of github.com:appleboy/gulp-compass: (30 commits)
  bump version.
  Ensured the path emitted is correct and added test for absolute paths
  Allowed use of absolute paths in compass options
  Update .jshintrc
  update jshint
  bump to 2.0.1
  ignore jshint error "Expected an assignment or function call and instead saw an expression."
  updated test description to match implementation
  normalize css and sass paths before compiling with compass - fixes appleboy#77
  fixed warning about which module
  update readme
  bump to 2.0.0
  add http_path and generated_images_path.
  fixed appleboy#75 .pipe(gulp.dest(dest)) not working.
  hide comment line as default.
  Implemented --http-path compass option
  Allow passing of --generated-images-path to compass (fixes appleboy#37)
  remove install sass
  add Dependency Status
  Bumping minor version
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants