Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Issue 5 - episode number in URL #10

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Issue 5 - episode number in URL #10

merged 2 commits into from
Oct 4, 2021

Conversation

DvdQzd
Copy link
Contributor

@DvdQzd DvdQzd commented Oct 4, 2021

Solves #5

Copy link
Owner

@applejag applejag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations, you are the first contributor to this repo 🎉 ❤️

Could you remove the dependency on query-string?

src/App.svelte Outdated Show resolved Hide resolved
@applejag applejag added the enhancement New feature or request label Oct 4, 2021
Copy link
Owner

@applejag applejag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR! Small and concise

@applejag
Copy link
Owner

applejag commented Oct 4, 2021

Thank you very much for contributing!

@applejag applejag merged commit 991acd0 into applejag:master Oct 4, 2021
@applejag
Copy link
Owner

applejag commented Oct 4, 2021

Hey @DvdQzd, I forgot to license this repo. I wish to license this under GNU GPL v3, and by obligation I have to ask you if you're OK with that as your code is in the repo now.

Are you fine by licensing your contribution under GNU GPL v3?

@DvdQzd
Copy link
Contributor Author

DvdQzd commented Oct 4, 2021

Sure. No problem!

@applejag applejag mentioned this pull request Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants