Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

Chore(Player bridge): Added custom configuration to player bridge #32

Merged
merged 3 commits into from
Apr 8, 2018

Conversation

reuvenlevitsky
Copy link

@reuvenlevitsky reuvenlevitsky commented Apr 8, 2018

Description:

Added custom configuration to player bridge

Known Issues:

Checklist for this pull request

  • PR is scoped to one task
  • Tests are included
  • Documentation included
  • One of:
    • The PR is not making any UI change
    • The PR is making a UI change but not a product change
      • Screenshots included

Thank you!

Copy link
Contributor

@lomudi lomudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@reuvenlevitsky reuvenlevitsky merged commit c8b9093 into master Apr 8, 2018
@reuvenlevitsky reuvenlevitsky deleted the addedCustomConfigurationToPlayerBridge branch April 8, 2018 08:30
@BoazWarshawsky
Copy link

Hi @reuvenlevitsky, sorry for the question but I wonder if this is a functionality in the level of the developers only or ZAPP/Support?
where is that configuration located? we should rebuild after changing it?

@reuvenlevitsky
Copy link
Author

reuvenlevitsky commented Apr 9, 2018

Developers only. JS and native devs. The configuration comes from JS - React native.

@BoazWarshawsky
Copy link

thanks @reuvenlevitsky

@francois-codes
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants