feat: use lassie for retrievals #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 20.90% // Head: 5.70% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
==========================================
- Coverage 20.90% 5.70% -15.21%
==========================================
Files 16 10 -6
Lines 2334 1490 -844
==========================================
- Hits 488 85 -403
+ Misses 1816 1401 -415
+ Partials 30 4 -26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@rvagg @kylehuntsman 's PR is merged can we move this forward? Any reason not to? |
|
application-research/filclient#112 is the blocker, and it's blocked by having a tagged boost—we could just use an untagged master over there but I don't think we need to rush this, I'm happy to keep this branch updated on both ends for now |
elijaharita
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not intended to be merged (yet anyway, we can have that conversation later). This is for dev purposes to make sure we get interfaces right and give me something functional so I can actually use code over in lassie for something real.
Depends on: