Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection inconsistencies on /content/add #258

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Conversation

gmelodie
Copy link
Contributor

@gmelodie gmelodie commented Jun 8, 2022

Inspired by #168 this PR does the following:

  1. fixes /content/add so it doesn't create CollectionRefs that have a null path field
  2. changes the database to require a couple fields on collection_refs to be not null
  3. makes coluuid and colpath query parameters on /content/add, not form values (consistent with other endpoints that use collections)
  4. makes /collections/fs/list return an empty list instead of null when no entries are found

@gmelodie gmelodie added Bug Something that should be fixed. Documentation Improvements or addition to documentation labels Jun 8, 2022
@gmelodie gmelodie self-assigned this Jun 8, 2022
@en0ma
Copy link
Contributor

en0ma commented Jun 8, 2022

makes coluuid and colpath query parameters on /content/add, not form values (consistent with other endpoints that use collections)

@gmelodie please make sure this change is done across shuttle, shuttle-proxy, barge, and any bash script in scripts dir

@gmelodie gmelodie force-pushed the fix-content-add branch 2 times, most recently from 4d25b89 to 0e66343 Compare June 9, 2022 16:15
@en0ma
Copy link
Contributor

en0ma commented Jun 10, 2022

@gmelodie I don't see shuttle-proxy and barge changes

@gmelodie
Copy link
Contributor Author

@en0ma shuttle-proxy propagates query params so we don't need to update it, and barge doesn't seem to support collections (maybe add the support on a separate PR?)

@gmelodie gmelodie merged commit 3413c3e into master Jun 10, 2022
@en0ma en0ma deleted the fix-content-add branch June 14, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something that should be fixed. Documentation Improvements or addition to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants