Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added docker images to the release pipeline #281

Merged
merged 3 commits into from
Jun 18, 2022
Merged

Added docker images to the release pipeline #281

merged 3 commits into from
Jun 18, 2022

Conversation

10d9e
Copy link
Contributor

@10d9e 10d9e commented Jun 18, 2022

No description provided.

@10d9e 10d9e linked an issue Jun 18, 2022 that may be closed by this pull request
Add docker builds to release pipeline #279
Closed
@10d9e 10d9e self-assigned this Jun 18, 2022
alvin-reyes
alvin-reyes approved these changes Jun 18, 2022
View reviewed changes
Copy link
Contributor

@alvin-reyes alvin-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to take note that we would need to change the tags if we eventually decide to create our own dockerhub account.

@10d9e
Copy link
Contributor Author

10d9e commented Jun 18, 2022

LGTM. Just need to take note that we would need to change the tags if we eventually decide to create our own dockerhub account.

That's a good point, maybe I'll factor this out into variable.

alvin-reyes
alvin-reyes reviewed Jun 18, 2022
View reviewed changes
.github/workflows/docker.yml
with:
context: .
push: true
tags: ${{ secrets.DOCKERHUB_ORG }}/estuary:latest , ${{ secrets.DOCKERHUB_ORG }}/estuary:${{ steps.get_version.outputs.VERSION }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

@10d9e 10d9e merged commit 42ebba6 into master Jun 18, 2022
@10d9e 10d9e deleted the 279-add-docker-builds-to-release-pipeline branch June 18, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-reyes alvin-reyes alvin-reyes approved these changes

@gmelodie gmelodie Awaiting requested review from gmelodie

@en0ma en0ma Awaiting requested review from en0ma

@elijaharita elijaharita Awaiting requested review from elijaharita

Assignees

@10d9e 10d9e

Labels
None yet
Projects
Estuary Engineering Task Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docker builds to release pipeline
2 participants
@10d9e @alvin-reyes