Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Improve pinning implementation to meet spec compliance #290

Merged
merged 12 commits into from Jun 24, 2022

Conversation

en0ma
Copy link
Contributor

@en0ma en0ma commented Jun 23, 2022

This PR does a refactor of the pinning implementation to make sure it is compliant with the pinning spec

NB: I have done the manual testing as well using the compliance audit tool

closes #275

@en0ma en0ma changed the title Refactor/improve pinning service for compliance Refactor: Improve pinning implementing to meet service compliance Jun 23, 2022
@10d9e
Copy link
Contributor

10d9e commented Jun 23, 2022

This is awesome. Maybe not for this PR, but do you think it would be possible to include an adhoc Pinning Service Compliance check that we could put into the pipeline?

@en0ma
Copy link
Contributor Author

en0ma commented Jun 23, 2022

This is awesome. Maybe not for this PR, but do you think it would be possible to include an adhoc Pinning Service Compliance check that we could put into the pipeline?

If we are to implement this, It would require cloning the compliance repo and running the audit against a running estuary server on the pipeline.

Also, the compliance team intends to add a pipeline where, as they improve the requirements and checks, it runs against pinning services prod API and notifies (creates an issue) on the service repo.

@en0ma en0ma changed the title Refactor: Improve pinning implementing to meet service compliance Refactor: Improve pinning implementation to meet service compliance Jun 23, 2022
@en0ma en0ma changed the title Refactor: Improve pinning implementation to meet service compliance Refactor: Improve pinning implementation to meet spec compliance Jun 23, 2022
cmd/estuary-shuttle/main.go Outdated Show resolved Hide resolved
pinning.go Outdated Show resolved Hide resolved
pinning.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alvin-reyes alvin-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SgtPooki
Copy link

This is awesome. Maybe not for this PR, but do you think it would be possible to include an adhoc Pinning Service Compliance check that we could put into the pipeline?

This is a great feature request. I opened ipfs-shipyard/pinning-service-compliance#140 to track it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Estuary pinning service to meet compliance
4 participants