Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the username taken validation #298

Merged
merged 3 commits into from
Jun 29, 2022
Merged

chore: fix the username taken validation #298

merged 3 commits into from
Jun 29, 2022

Conversation

alvin-reyes
Copy link
Contributor

Fix to validate the user pointer AND the actual username upon registration

Verification

Test data. Only 3 users available on my DB.

image

Add new user

Add alvinreyes2
image

Added alvinreyes2 successfully with the invite code
image

Tried adding alvinreyes2 again
image

@10d9e
Copy link
Contributor

10d9e commented Jun 29, 2022

It looks like shuttle-4 is down causing the tests to fail

handlers.go Show resolved Hide resolved
@alvin-reyes
Copy link
Contributor Author

It looks like shuttle-4 is down causing the tests to fail

Shuttle4 is now up and running.

@alvin-reyes alvin-reyes merged commit 3c52780 into master Jun 29, 2022
@en0ma en0ma deleted the uname-fix branch June 29, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants