Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stats + include size and createdAt in response #631

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Fix stats + include size and createdAt in response #631

merged 2 commits into from
Dec 5, 2022

Conversation

neelvirdy
Copy link
Contributor

  1. No longer counts deleted pins in stats
  2. Consistently excludes aggregates from stats
  3. Adds size and createdAt fields to content stats response
  4. Removes some unreachable code

Accompanies this FE PR: application-research/estuary-www#117

before:
image

after:
image

@neelvirdy neelvirdy mentioned this pull request Nov 30, 2022
Merged
@neelvirdy neelvirdy mentioned this pull request Dec 1, 2022
Open
@10d9e 10d9e assigned 10d9e and neelvirdy and unassigned 10d9e and neelvirdy Dec 1, 2022
@neelvirdy neelvirdy requested a review from en0ma December 2, 2022 03:04
en0ma
en0ma reviewed Dec 2, 2022
View reviewed changes
handlers.go Show resolved Hide resolved
en0ma
en0ma reviewed Dec 2, 2022
View reviewed changes
handlers.go Outdated Show resolved Hide resolved
@neelvirdy neelvirdy requested a review from en0ma December 5, 2022 06:19
alvin-reyes
alvin-reyes approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@alvin-reyes alvin-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neelvirdy neelvirdy merged commit f69b3e6 into application-research:dev Dec 5, 2022
@neelvirdy neelvirdy deleted the nvirdy/option-for-no-aggr branch December 5, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-reyes alvin-reyes alvin-reyes approved these changes

@en0ma en0ma en0ma approved these changes

@gmelodie gmelodie Awaiting requested review from gmelodie

@kelindi kelindi Awaiting requested review from kelindi

Assignees

@neelvirdy neelvirdy

Labels
None yet
Projects
Estuary Engineering Task Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@neelvirdy @alvin-reyes @en0ma @10d9e