Handle pin failures during consolidation to prevent stuck staging zones #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en0ma
reviewed
Dec 6, 2022
en0ma
reviewed
Dec 6, 2022
en0ma
reviewed
Dec 6, 2022
en0ma
reviewed
Dec 6, 2022
en0ma
reviewed
Dec 6, 2022
neelvirdy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle pin failures during consolidations by removing the failed contents from the staging zone and unmarking it as consolidating, so the staging worker will retry consolidation without the failed contents on the next interval.
Also, prevent staging zones from getting stuck in consolidating when the take content command doesn't even get successfully sent to the shuttle.