-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overwrite content in collection when same fullPath #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gmelodie there are multiple places contents are added to a collection. It would be nice to abstract the add content to collection logic (with the override flag) and use it everywhere |
@en0ma done! Can you help testing? |
en0ma
reviewed
Dec 10, 2022
Let's fix the conflicts. |
Oh yes! Let's get this merged please. It will fix one of the rclone tests. See rclone/rclone#5854 (comment) |
gmelodie
force-pushed
the
gabe/collection-path-overwrite
branch
from
December 19, 2022 12:23
1700d3f
to
fa4d1bf
Compare
Tested
|
anjor
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if you specify
overwrite=true
it will replace the file with the same name on the collection, and it'll error out if you try doing so without the flag.Fixes #436