Refactor pin estuary native: part 1 #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check e2fe0ea to see that the two codepaths are the same, at which point I decided to delete |
|
Hmm, looks like swagger just deletes the whole thing if I don't keep the function + godocs. I am happy to go either way -keep |
github-actions
bot
force-pushed
the
anjor/refactor-pin-estuary-native
branch
from
eeb274d
to
3600798
Compare
|
Discussed offline with @en0ma, we are deleting this endpoint in api v2. In the meantime, just delegating the call to handleAddPin. |
en0ma
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.