Use ExpirableLRU to cache http requests with TTL #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neelvirdy
force-pushed
the
nvirdy/caching
branch
from
f085522
to
3198243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpirableLRUcaches for caching certain http requests with two options of TTL (10 seconds, 60 minutes)./content/contents,/content/staging-zones/*, part of/public/stats/public/stats,/public/metrics/deals-on-chainNote: I only included the 10 second cache for apiV2 because the extended cache endpoints should be moved to metrics API, and I'm not expecting them to be rewritten under apiV2. So, there's no need for the extended cache there.