Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sp endpoints v2 (Revision B) (2) #847

Merged
merged 9 commits into from
Jan 10, 2023
Merged

Conversation

jcace
Copy link
Contributor

@jcace jcace commented Jan 9, 2023

Closes #578

This is revision B as the original PR was reverted, since it broke V1. (#831)

In this new PR, V1 has been left completely untouched to avoid anything breaking.

@jcace
Copy link
Contributor Author

jcace commented Jan 9, 2023

@snissn any ideas why the postman tests are failing? I've added some jsoverrides but I'm not entirely sure how it's working or why they're failing

@snissn
Copy link
Contributor

snissn commented Jan 10, 2023

storage-providers_unsuspend_sp_PUT.js

use the file format above instead of

v2_storage-providers_claim_sp_GET.js

and the overrides should work!

@jcace jcace requested a review from snissn January 10, 2023 20:41
Copy link
Contributor

@snissn snissn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very good

@jcace jcace merged commit 6b7c99b into dev Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create /storage-providers endpoint
2 participants