Skip to content
This repository has been archived by the owner on Jul 20, 2021. It is now read-only.

make notebooks run faster #30

Closed
jairideout opened this issue Apr 11, 2014 · 4 comments
Closed

make notebooks run faster #30

jairideout opened this issue Apr 11, 2014 · 4 comments
Milestone

Comments

@jairideout
Copy link
Collaborator

The tests take ~40 minutes via Travis, which is running through all of the notebooks. Once we hit 50 minutes, Travis will abort the tests. Most of the cells run instantly, or with little delay, but some cells take several minutes to complete. @gregcaporaso thoughts on this?

Travis also requires that there is some sort of output printed within a 10-minute window, otherwise the tests will be killed. We're currently okay, but there are some cells that are likely close to this threshold.

@gregcaporaso
Copy link
Member

I can think about optimizing some of the things that are going slow. There
are some long hanging fruit (it's probably about 3 cells accounting for
most of the runtime, though those cells are illustrating some important
ideas).

On Fri, Apr 11, 2014 at 3:34 PM, Jai Ram Rideout
notifications@github.comwrote:

The tests take ~40 minutes via Travis, which is running through all of the
notebooks. Once we hit 50 minutes, Travis will abort the tests. Most of the
cells run instantly, or with little delay, but some cells take several
minutes to complete. @gregcaporaso https://github.com/gregcaporasothoughts on this?

Travis also requires that there is some sort of output printed within a
10-minute window, otherwise the tests will be killed. We're currently okay,
but there are some cells that are likely close to this threshold.

Reply to this email directly or view it on GitHubhttps://github.com/gregcaporaso/An-Introduction-To-Applied-Bioinformatics/issues/30
.

@jairideout
Copy link
Collaborator Author

Great, sounds good!

@gregcaporaso
Copy link
Member

Most of the parts that run slow are places where I'm trying to show how the runtime of an algorithm changes with more sequences, longer sequences, etc. The bottleneck for all of them is that the Smith-Waterman/Needleman-Wunsch implementations that I'm calling are the ones that I implemented in python for IAB. When biocore's #117 is merged, I can re-work the code that uses alignments under-the-hood (msa functions, clustering functions) to call SSW, and this issue will largely be addressed.

@gregcaporaso
Copy link
Member

This has mostly been addressed so closing this issue, but we desperately need a faster global aligner in scikit-bio (scikit-bio/scikit-bio#254, scikit-bio/scikit-bio#555)!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants