Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tx_convert in witness #261

Merged
merged 2 commits into from Jan 5, 2022
Merged

fix tx_convert in witness #261

merged 2 commits into from Jan 5, 2022

Conversation

lispc
Copy link
Collaborator

@lispc lispc commented Jan 5, 2022

in a previous commit, in witness.rs, the tx steps for evm citcuit are incorrectly converted to empty vec, as a result, no steps are really tested.

@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member T-opcode Type: opcode-related and focused PR/Issue labels Jan 5, 2022
@lispc lispc mentioned this pull request Jan 5, 2022
Merged
han0110
han0110 approved these changes Jan 5, 2022
View reviewed changes
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

ChihChengLiang
ChihChengLiang approved these changes Jan 5, 2022
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChihChengLiang ChihChengLiang merged commit 0c9cf1c into privacy-scaling-explorations:main Jan 5, 2022
@lispc lispc deleted the fix/tx_convert branch January 5, 2022 10:22
@lispc lispc mentioned this pull request Feb 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

@han0110 han0110 han0110 approved these changes

Assignees
No one assigned
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member T-opcode Type: opcode-related and focused PR/Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lispc @ChihChengLiang @han0110