Bug fix to NoSpaceInEmphasisRule to ignore code blocks

appmattus · Mar 13, 2019 · 0124c1a · 0124c1a
1 parent 8cc60c8
commit 0124c1a
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/markdown/src/main/kotlin/com/appmattus/markdown/rules/NoSpaceInEmphasisRule.kt b/markdown/src/main/kotlin/com/appmattus/markdown/rules/NoSpaceInEmphasisRule.kt
@@ -1,8 +1,11 @@
 package com.appmattus.markdown.rules
 
-import com.appmattus.markdown.processing.MarkdownDocument
 import com.appmattus.markdown.dsl.RuleSetup
 import com.appmattus.markdown.errors.ErrorReporter
+import com.appmattus.markdown.processing.MarkdownDocument
+import com.vladsch.flexmark.ast.Code
+import com.vladsch.flexmark.ast.FencedCodeBlock
+import com.vladsch.flexmark.ast.IndentedCodeBlock
 
 /**
  * # Spaces inside emphasis markers
@@ -46,7 +49,9 @@ class NoSpaceInEmphasisRule(
 
     override fun visitDocument(document: MarkdownDocument, errorReporter: ErrorReporter) {
 
-        document.allText.forEach {
+        document.allText.filterNot {
+            it.parent is FencedCodeBlock || it.parent is IndentedCodeBlock || it.parent is Code
+        }.forEach {
             if (it.chars.contains(startRegex) || it.chars.contains(endRegex)) {
                 errorReporter.reportError(it.startOffset, it.endOffset, description)
             }

diff --git a/markdown/src/test/resources/spaces_inside_emphasis_markers.md b/markdown/src/test/resources/spaces_inside_emphasis_markers.md
@@ -33,3 +33,19 @@ One-sided * broken emphasis* {NoSpaceInEmphasisRule}
 Don't _flag on _words with underscores before them.
 
 The same goes for words* with asterisks* after them.
+
+```text
+/*
+ *
+ * Ignore code blocks
+ *
+ */
+```
+
+    /**
+     *
+     * Ignore * code * blocks
+     *
+     */
+
+`/* Ignore * code * blocks */`