Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #839 - add pull request template #840

Merged
merged 1 commit into from
Dec 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
## Standards checklist:

<!-- Fill with an x the ones that apply. Example: [x] -->

- [ ] The PR title is descriptive.
- [ ] The PR doesn't replicate another PR which is already open.
- [ ] I have read the contribution guide and followed all the instructions.
- [ ] The code follows the code style guide detailed in the wiki.
- [ ] The code is mine or it's from somewhere with an MIT-compatible license.
- [ ] The code is efficient, to the best of my ability, and does not waste computer resources.
- [ ] The code is stable and I have tested it myself, to the best of my abilities.
- [ ] If the code introduces new aliases, I provide a valid use case for all plugin users down below.

## Changes:

- [...]

## Other comments:

...
2 changes: 2 additions & 0 deletions docs/CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
09/03/2023 Version 4.5.0-beta1
- GitHub template for pull requests (#839)
- handle IPv6 fragment extension header (#832 #837)
- configure.ac: unify search dirs for pcap and add lib32 (#819)
- nanosecond timestamps (#796)
- low PPS values run at full speed after several days (#779)
- create DLT_LINUX_SLL2 plugin (#727)
Expand Down
4 changes: 4 additions & 0 deletions docs/CREDIT
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,7 @@ GithHub @plangarbalint

Chuck Cottrill <GitHub @ChuckCottrill>
- handle IPv6 fragment extensions


Martin 'JaMa' Jansa <GitHub @shr-project>
- configure.ac: unify search dirs for pcap and add lib32