Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FED-1220 feat (cmp: modal) add modal option and update styling #144

Closed
wants to merge 33 commits into from
Closed

FED-1220 feat (cmp: modal) add modal option and update styling #144

wants to merge 33 commits into from

Conversation

potench
Copy link
Contributor

@potench potench commented Nov 20, 2019

background

  • add optional modal styling for initial consent Banner
  • update Banner styling for legibility and move purposes to last
  • Allow override of purposes, vendors, and features from purposes.json and languages.js

test plan

yarn test

potench added 30 commits June 8, 2018 17:34
@potench
(docs)
8845ebe
@potench
Merge pull request #2 from Openmail/potench/pr-template-2
cf7522a 
(docs)
@potench
Feature/pr test 2 (#3)
50ce53a 
* (docs) testing pr template

* (docs)
@potench
Create PULL_REQUEST_TEMPLATE.md
61ee2ba
@potench
Create CONTENT_SITE_PR_TEMPLATE.md
9659c0b
@potench
Update PULL_REQUEST_TEMPLATE.md
6c55c57
@potench
Merge branch 'master' of https://github.com/appnexus/cmp
a75f1f4
@potench
(merge) upstream merge and remove pr_template tests
f28b53d
@potench
Merge branch 'master' of https://github.com/appnexus/cmp
c95af02
@potench
PLTX-2337 (refactor) upgrade to latest CMP from appnexus (#4)
04052cd 
* (refactor) partial migration

* (migrate) upgrade to latest cmp and move to openmail repo

* (refactor) fix webpack dev server for s1

* (refactor) add cross-var and update deploy:s1 npm scripts

* (feat) deploy:s1

* (refactor) move to configure dir

* (refactor) reorganize files

* (refactor) deploy s1 and deploy original separately to s3 bucket

* (refactor) reogranize loader files and update deploy

* (feat) added .node_version

* (refactor) remove codesmell from package json and babel config
@potench
Update README.md
517ccc0
@potench
(refactor) move reference.html to version folder
f6c710d
@potench
(refactor) fix links on s1/reference html file
1aefceb
@potench
(refactor) use S1 color for popup
be5af53
@potench
potench/upgrade cmp 0.0.1 (#5)
52176d1 
* Add gdprAppliesGlobally flag as independent config property

* Truncate metadata string to match spec

* Update a couple dependencies
@potench
upgrade (all) update to 89504d7
839e821
@potench
upgrade cmp
e812f37
@potench
update style vars
61478fc
@potench
upstream merge and handle combining with customization from modal branch
601a5d8
@potench
fix tests
b133978
@potench
bump
14534a4
@potench
bump
6bcb3d7
@potench
fix pubVendorConsent to check against known vendors
e6d7e0e
@potench
adds footer / removes import tests because import isnt implemented co…
a6bd8f1 
…rrectly
@potench
remove FOUC
5508e00
@potench
update with compliant text
172af1a
@potench
FED-1162 upgrade (all) update to 89504d7 (#14)
007df8d 
* upgrade (all) update to 89504d7

* upgrade cmp

* update style vars

* upstream merge and handle combining with customization from modal branch

* fix tests

* bump

* bump

* fix pubVendorConsent to check against known vendors

* adds footer / removes import tests because import isnt implemented correctly

* remove FOUC
@potench
fix (build) add cross-var package
eff8752
@potench
fix (build) add s3-deploy package
ae705e0
@potench
FED-1184 feat (ui: features) add ui for features names and descriptio…
45bc10d 
…ns per vendor (#16)

* feat (ui: features) add ui for features names and descriptions per vendor

* remove console logs
@potench
FED-1193 refactor (banner: ui) provide a direct link to the vendor li…
c4ed5c9 
…st in first UI layer (#17)
@potench
FED-1221 refactor (init: events) only emit consent-change when no err…
487dea3 
…or (#18)

* FED-1221 refactor (init: events) only emit consent-change when no error

* add more tests

* add option to auto-upgrade consent with footer

* docs and tests

* fix onConsent event

* fix auto quotes

* fix bracket spacing
@potench
FED-1220 feat (cmp: modal) add modal option and update styling
14a47a0
@potench potench closed this Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@potench