Added ChevronIcon and Expander components. #160
Conversation
…l data changes instead of on every expand and collapse. Added unit tests.
…h component. Added some labels for the LabeledSwitch's interactive, non-changing labels example. Added Expander component to the exported modules.
|
I'm having some issues with the width and height of the fake button that the |
| * Child element whose children represents content to be shown next to | ||
| * the expander icon. | ||
| */ | ||
| Label: any |
There was a problem hiding this comment.
We might not need this anymore since @ogupte has fixed the docs generator
There was a problem hiding this comment.
we do still need this for the time being, i need make the docs parsing better to support lucid child components
|
|
||
| return ( | ||
| <div | ||
| {..._.omit(passThroughs, 'onExpand')} |
There was a problem hiding this comment.
is this omit necessary? div probably ignores props it doesn't recognize.
|
|
| const nextLabel = _.first(Expander.Label.findInAllAsProps(nextProps)).children; | ||
|
|
||
| if (currentLabel !== nextLabel) { | ||
| this._labelKey++; |
There was a problem hiding this comment.
It's sad that this is necessary :(
There was a problem hiding this comment.
Agreed, we couldn't find any sane way to detect if the content changed :(
…s/lucid into feature/ANXR-190-expand-collapse Conflicts: src/components/Expander/Expander.jsx src/components/Expander/Expander.reducers.js src/components/Expander/Expander.spec.jsx
Docspot demo: http://docspot.devnxs.net/projects/lucid/feature-ANXR-190-expand-collapse/#/components/Expander
PR Checklist
commonat minimum)semver-labels