Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Use ARG to reference version of dependencies #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use ARG to reference version of dependencies #32

wants to merge 1 commit into from

Conversation

masih
Copy link

@masih masih commented Oct 21, 2019

  • Use ARG to reference snaptel version.
    This allows the version of snaptel agent to change during build for debugging and development purposes.

@@ -2,7 +2,7 @@ FROM ubuntu:xenial

LABEL maintainer='Chris Rust <chris.rust@solarwinds.com>'

ENV APPOPTICS_SNAPTEL_VERSION '2.0.0-ao1.1919'
ARG APPOPTICS_SNAPTEL_VERSION='2.0.0-ao1.1919'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can args be read as environment variables as well?
If not should be something like

ARG APPOPTICS_SNAPTEL_VERSION='2.0.0-ao1.1919'
ENV APPOPTICS_SNAPTEL_VERSION=${APPOPTICS_SNAPTEL_VERSION}

Copy link
Author

@masih masih Oct 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Beau how is it going?
During build the ARG is available as if it is an environment variable.
Outside of it, is that environment variable elsewhere during runtime? I can't find it.

Is it required that the version is available as environment variable at runtime?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye I just checked the repo, looks like its only used for the package manager in the dockerfile 👍

Copy link
Contributor

@Beaujr Beaujr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can arg

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants