MRPHS-5166 : GCP cloud creation via c3ntry <DO NOT MERGE> #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepali-gunwant
changed the title
avnish30jn
reviewed
Apr 16, 2018
| ClientEmail string `json:"client_email"` | ||
| ClientId string `json:"client_id"` | ||
| // AccountFile represents the structure of the account file JSON file. | ||
| type AccountFile struct { |
There was a problem hiding this comment.
is there any specific reason to expose the struct ?
| @@ -524,6 +562,7 @@ func (vm *VM) GetZoneList() ([]Zone, error) { | |||
| Region: regionName, | |||
| Status: zone.Status, | |||
| }) | |||
|
|
|||
| } | ||
|
|
||
| // Packer visor image config for GCP cloud | ||
| type VisorImageConfig struct { |
| @@ -225,11 +227,47 @@ type Project struct { | |||
| CreateTime string `json:"create_time,omitempty"` | |||
| } | |||
|
|
|||
| // Packer visor image config for GCP cloud | |||
| type GcpConfig struct { | |||
| // GetName returns the name of the virtual machine. | ||
| func (vm *VM) GetName() string { | ||
| return vm.Name | ||
| } | ||
|
|
||
| // Creates a visor image config required for packer | ||
| func (vm *VM) CreateVisorImageConfig(accountFile, packerConf string) ([]byte, error) { |
There was a problem hiding this comment.
should we return only the gcp builder here and merge where we are dumping this in a file (c3ntry) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira-id
https://apporbit.atlassian.net/browse/MRPHS-5166
Problem
We need to support GCP cloud creation via c3ntry. In the new version of cloud creation keeper installation will be done via packer.
Resolution
Testing
In progress