Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introducing Agent Serialization #60

Closed
eharpste opened this issue Jun 5, 2020 · 1 comment
Closed

Re-introducing Agent Serialization #60

eharpste opened this issue Jun 5, 2020 · 1 comment
Assignees
@cmaclell @eharpste @DannyWeitekamp
Labels
API Usability Issues related to making the system easier to use on a software level help wanted Refactoring Stuff that makes things easier for us

Comments

@eharpste
Copy link
Member

eharpste commented Jun 5, 2020

We would like to return to having the ability to serialize agents to store and retrieve them between runs.
@eharpste eharpste added Refactoring Stuff that makes things easier for us API Usability Issues related to making the system easier to use on a software level labels Jun 5, 2020
@eharpste eharpste mentioned this issue Jun 5, 2020
Closed
eharpste added a commit that referenced this issue Jul 7, 2021
@eharpste
Merge pull request #78 from RachWei/master
a80ea68 
This merge adds in several additional integration tests that were on the [expanded_tests](https://github.com/apprenticelearner/AL_Core/tree/expanded-tests) branch, this is relevant to but does not address #72 . It also implements a test for agent serialization and re-introduces database saving of agents talked about in #60 . The changes also remove all un-commented print statements and replace them with use of the built in logging library as talked about in #73 .
@eharpste
Copy link
Member Author

eharpste commented Jul 7, 2021

Agent serialization has been re-enabled by the recent pull request (#78). It seems to be working as expected at least for numbert based ModularAgents. The new test_save seems to imply that it will also work for fo_planner based agents but additional testing might be required. Since the fo_planner based agent is slated for eventual deprecation I'm not too worried about making serialization work for it.

@eharpste eharpste closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmaclell cmaclell

@eharpste eharpste

@DannyWeitekamp DannyWeitekamp

Labels
API Usability Issues related to making the system easier to use on a software level help wanted Refactoring Stuff that makes things easier for us
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cmaclell @eharpste @DannyWeitekamp