Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Thor to 1.0.0 #90

Merged
merged 3 commits into from
May 28, 2021
Merged

Update Thor to 1.0.0 #90

merged 3 commits into from
May 28, 2021

Conversation

jmks
Copy link
Contributor

@jmks jmks commented Feb 29, 2020

HI!

I noticed the TravisCI config contains several older Rubies and hasn't seem a commit in awhile. Is it still being maintained?

The old version of thor is preventing us from upgrading some other gems so here's a patch to upgrade it. The thorfile is pretty simple so doesn't seem like an issue.

The before_install code was stolen borrowed with ❤️ from puma.

@mvgijssel
Copy link

Same problem! Would love to see this merged as well.

@badosu
Copy link

badosu commented Sep 27, 2020

This would be helpful indeed, we are currently locked on solargraph v0.38.x due to this restriction.

@jmks
Copy link
Contributor Author

jmks commented Sep 27, 2020

We made a fork for work, so we could continue upgrading other gems: https://github.com/nulogy/approvals

We use the gem only a bit so we're leaning towards replacing the approval specs with plain RSpec.

@geeksam
Copy link
Contributor

geeksam commented May 28, 2021

Hello! I recently offered to help out with this gem, but it's going to take me a little while to get up to speed. :) Thanks for submitting the PR (especially the Travis changes!). I haven't seen any tests around the CLI that uses Thor, so I'll take a quick look to make sure it at least runs before I merge this.

@geeksam
Copy link
Contributor

geeksam commented May 28, 2021

Looks good at first glance. However, I haven't tried releasing this gem to rubygems.org yet and I'm at the end of my workday, so I'll come back to this soon :)

@geeksam
Copy link
Contributor

geeksam commented May 28, 2021

...on second thought, I can at least merge this, even if I don't release right away.

@geeksam geeksam merged commit 4437dc5 into approvals:master May 28, 2021
@geeksam geeksam self-assigned this May 28, 2021
@geeksam
Copy link
Contributor

geeksam commented May 28, 2021

0.0.25 pushed to rubygems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants