-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Thor to 1.0.0 #90
Conversation
Same problem! Would love to see this merged as well. |
This would be helpful indeed, we are currently locked on solargraph |
We made a fork for work, so we could continue upgrading other gems: https://github.com/nulogy/approvals We use the gem only a bit so we're leaning towards replacing the approval specs with plain RSpec. |
Hello! I recently offered to help out with this gem, but it's going to take me a little while to get up to speed. :) Thanks for submitting the PR (especially the Travis changes!). I haven't seen any tests around the CLI that uses Thor, so I'll take a quick look to make sure it at least runs before I merge this. |
Looks good at first glance. However, I haven't tried releasing this gem to rubygems.org yet and I'm at the end of my workday, so I'll come back to this soon :) |
...on second thought, I can at least merge this, even if I don't release right away. |
0.0.25 pushed to rubygems. |
HI!
I noticed the TravisCI config contains several older Rubies and hasn't seem a commit in awhile. Is it still being maintained?
The old version of thor is preventing us from upgrading some other gems so here's a patch to upgrade it. The thorfile is pretty simple so doesn't seem like an issue.
The
before_install
code wasstolenborrowed with ❤️ from puma.