Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 引数の型を EmojiEvent に修正 #700

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Conversation

MikuroXina
Copy link
Collaborator

Type of Change:

型の修正

Details of implementation (実施内容)

EmojiLog の第 1 引数の型は EmojiEvent となるべきですがなぜか RoleEvent 型になっていたので修正しました.

@MikuroXina MikuroXina added the C-bug Category: bug label Feb 3, 2023
@MikuroXina MikuroXina requested a review from m1sk9 February 3, 2023 17:51
@MikuroXina MikuroXina self-assigned this Feb 3, 2023
@MikuroXina MikuroXina enabled auto-merge (squash) February 3, 2023 17:52
@codecov-commenter
Copy link

Codecov Report

Merging #700 (744e395) into main (800c6c1) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #700   +/-   ##
=======================================
  Coverage   72.43%   72.43%           
=======================================
  Files          67       67           
  Lines        4694     4694           
  Branches      443      443           
=======================================
  Hits         3400     3400           
  Misses        854      854           
  Partials      440      440           
Flag Coverage Δ
unittests 72.43% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/emoji-log.ts 56.66% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/service/emoji-log.ts Outdated Show resolved Hide resolved
@MikuroXina MikuroXina merged commit bfc69ff into main Feb 4, 2023
@MikuroXina MikuroXina deleted the fix/emoji-event branch February 4, 2023 04:26
This was referenced Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants