Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: エラーを一度しか出さないように修正 #751

Merged
merged 2 commits into from
Feb 25, 2023

Conversation

MikuroXina
Copy link
Collaborator

Type of Change:

バグの修正, テストの追加

Details of implementation (実施内容)

#749 のリファクタでエラーが 3 回出てしまうデグレードを起こしていました. そのためエラーが 1 回しか出ないように修正し, そのテストコードを追加しました.

@MikuroXina MikuroXina added the C-bug Category: bug label Feb 25, 2023
@MikuroXina MikuroXina self-assigned this Feb 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #751 (9aaa12e) into main (cdd3fc0) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   72.15%   72.13%   -0.03%     
==========================================
  Files          71       71              
  Lines        4752     4758       +6     
  Branches      468      466       -2     
==========================================
+ Hits         3429     3432       +3     
- Misses        856      861       +5     
+ Partials      467      465       -2     
Flag Coverage Δ
unittests 72.13% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/command/meme.ts 75.16% <50.00%> (-1.06%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MikuroXina MikuroXina enabled auto-merge (squash) February 25, 2023 07:58
Copy link
Contributor

@m1sk9 m1sk9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@MikuroXina MikuroXina merged commit 261050f into main Feb 25, 2023
@MikuroXina MikuroXina deleted the fix/report-error branch February 25, 2023 08:31
This was referenced Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants