This repository has been archived by the owner on Jan 23, 2019. It is now read-only.
Fix reschedule isuues #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support CanDOTimeout
- set timeout for every running job - monitor all running job & remove if timeout expire
sadlil
suggested changes
Mar 6, 2017
pkg/server/server.go
Outdated
| j, ok := jb.(*Job) | ||
| if !ok { | ||
| log.Errorln("invalid job") | ||
| return |
There was a problem hiding this comment.
for one invalid jobs this is not loading the next ok jobs. print log and may be continue instead of return
pkg/server/server.go
Outdated
| sj, ok := sji.(*CronJob) | ||
| if !ok { | ||
| log.Errorln("invalid cronjob") | ||
| return |
There was a problem hiding this comment.
for one invalid jobs this is not loading the next ok jobs. print log and may be continue instead of return
pkg/server/server.go
Outdated
| @@ -93,6 +117,7 @@ func (s *Server) Start(addr string) { | |||
|
|
|||
| go registerWebHandler(s) | |||
| go s.WatcherLoop() | |||
| go s.JobTimeoutMonitorLoop() | |||
pkg/server/server.go
Outdated
| } | ||
|
|
||
| func (s *Server) JobTimeoutMonitorLoop() { | ||
| ticker := time.NewTicker(time.Second) |
There was a problem hiding this comment.
Instead of two block of code do
for tick := range time.NewTicker(time.Second) { ... }
ashiquzzaman33
force-pushed
the
sadlil/no-reschedule
branch
from
b79c2ed
to
15f3e20
Compare
…ob functions Signed-off-by: sadlil <sadlil@appscode.com>
sadlil
approved these changes
Mar 6, 2017
sadlil
approved these changes
Mar 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.