Support self-signed ca cert for backends #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptadas
reviewed
Jan 24, 2018
pkg/cli/env.go
Outdated
| @@ -52,6 +52,8 @@ const ( | |||
| // For authentication based on tokens | |||
| OS_STORAGE_URL = "OS_STORAGE_URL" | |||
| OS_AUTH_TOKEN = "OS_AUTH_TOKEN" | |||
| //For using certs in Mino server or REST server | |||
diptadas
reviewed
Jan 24, 2018
pkg/cli/restic.go
Outdated
|
|
||
| func (w *ResticWrapper) getCertFile() (string, error) { | ||
| certFile := w.scratchDir + "/cacerts/ca.crt" | ||
| if _, err := os.Stat(certFile); os.IsExist(err) { |
There was a problem hiding this comment.
shouldn't it be os.IsNotExist() ?
pkg/cli/restic.go
Outdated
| func (w *ResticWrapper) getCertFile() (string, error) { | ||
| certFile := w.scratchDir + "/cacerts/ca.crt" | ||
| if _, err := os.Stat(certFile); os.IsExist(err) { | ||
| return "", errors.New(certFile + " not exist.") |
diptadas
reviewed
Jan 24, 2018
pkg/cli/restic.go
Outdated
| @@ -46,14 +50,38 @@ type Snapshot struct { | |||
| func (w *ResticWrapper) ListSnapshots() ([]Snapshot, error) { | |||
| result := make([]Snapshot, 0) | |||
| args := w.appendCacheDirFlag([]interface{}{"snapshots", "--json"}) | |||
| if w.cacertEnabled { | |||
There was a problem hiding this comment.
add a function w.appendCaCertFlag()
pkg/cli/restic.go
Outdated
| @@ -151,3 +211,11 @@ func (w *ResticWrapper) appendCacheDirFlag(args []interface{}) []interface{} { | |||
| } | |||
| return append(args, "--no-cache") | |||
| } | |||
|
|
|||
| func (w *ResticWrapper) getCertFile() (string, error) { | |||
| certFile := w.scratchDir + "/cacerts/ca.crt" | |||
There was a problem hiding this comment.
use constant CertFilePath
tamalsaha
force-pushed
the
master
branch
3 times, most recently
from
624313e
to
4403d50
Compare
tamalsaha
force-pushed
the
cacerts
branch
5 times, most recently
from
64206d8
to
5259f26
Compare
tamalsaha
changed the title
tamalsaha
force-pushed
the
cacerts
branch
2 times, most recently
from
f2cccde
to
184791b
Compare
tamalsaha
approved these changes
Feb 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288