Broken annotations for standard Ingress resource

[miry]

I use 7.0.0-rc.1 version.

I tried to create a standard resource with features https://github.com/appscode/voyager/blob/master/docs/guides/ingress/pod-placement.md#using-node-selector

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: letsencrypt
  annotations:
    kubernetes.io/ingress.class: "voyager"
    ingress.appscode.com/type: HostPort
    ingress.appscode.com/replicas: '1'
    ingress.appscode.com/node-selector: '{"role": "edge"}'
    ingress.appscode.com/tolerations: '[{"key": "IngressOnly", "operator": "Equal", "value": "true", "effect": "NoSchedule"}]'
    ingress.appscode.com/workload-kind: DaemonSet
spec:
  rules:
    - host: 'logs.example.com
      http:
        paths:
        - path: /
          backend:
            serviceName: nginx
            servicePort: 80

And got:

 $ kubectl get daemonset               
NAME                  DESIRED   CURRENT   READY     UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE
voyager-letsencrypt   1         1         1         1            1           <none>          1m

There is missing tolerations and node selector.

[tamalsaha]

Hi, please check the syntax for node selector and toleration https://appscode.com/products/voyager/7.0.0-rc.1/guides/ingress/pod-placement/ . Try with the correct syntax, it should work. :) Please reopen if you see any issues.

[miry]

@tamalsaha in this guide there are example that valid for resource: apiVersion: voyager.appscode.com/v1beta1. And they are not valid for apiVersion: extensions/v1beta1.

[tamalsaha]

@miry , I have added pr #1059 to fix this. Can you try the image appscode/voyager:node-sel and let me know if that solves this?

In general, we prefer and recommend using the CRD, since it has lot more feature support in a natural way than shoving everything into a string->string map (annotations).

[tamalsaha]

This has been released as part of https://github.com/appscode/voyager/releases/tag/7.0.0-rc.2 release.