Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation about external-dns service #1120

Merged
merged 2 commits into from Jun 9, 2018
Merged

Fix documentation about external-dns service #1120

merged 2 commits into from Jun 9, 2018

Conversation

giovannicandido
Copy link
Contributor

I'm using HostPort type ingress.
For me annotation on service works, not on pod.

Using external-dns version 0.5.2

@codecov-io
Copy link

Codecov Report

Merging #1120 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1120   +/-   ##
======================================
  Coverage    3.64%   3.64%           
======================================
  Files         106     106           
  Lines       21010   21010           
======================================
  Hits          765     765           
  Misses      20114   20114           
  Partials      131     131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9673f43...b9b03e1. Read the comment docs.

@tamalsaha
Copy link
Contributor

Thanks @giovannicandido !

@tamalsaha tamalsaha merged commit 8ff44c5 into voyagermesh:master Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants