Haproxy exporter image repository #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These options actually appear in the chart, and allowing them to set means users can use their own naming convention when it comes to repositories. The defaults are what they were previuosly, so this change is backwards compatible Signed-off-by: Robert Kirk <robert.kirk@smarkets.com>
Signed-off-by: Robert Kirk <robert.kirk@smarkets.com>
This change may not actually be backwards compatible. If users have this option set currently, it will have no effect, and so if it's set to something other than the default (haproxy and voyager respectively), then the functionality will change. Signed-off-by: Robert Kirk <robert.kirk@smarkets.com>
tamalsaha
approved these changes
Apr 24, 2020
|
Thanks for your contribution, @RobertKirk ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options actually appear in the chart, and allowing them to set means
users can use their own naming convention when it comes to repositories.
The chart change may not actually be backwards compatible. If users have this
option set currently, it will have no effect, and so if it's set to something
other than the default (haproxy and voyager respectively), then the functionality
will change.
Fixes #1449
This is my first contribution, so let me know if the PR can be adjusted in any way.