Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open both port 443 & 80 when AWS cert manager is in use. #221

Merged
merged 1 commit into from Jun 19, 2017

Conversation

Projects
None yet
2 participants
@tamalsaha
Copy link
Member

commented Jun 19, 2017

cc: @julianvmodesto

Fixes #189

@tamalsaha tamalsaha requested a review from sadlil Jun 19, 2017

@tamalsaha tamalsaha added this to the 3.0.0 milestone Jun 19, 2017

@tamalsaha tamalsaha merged commit 38ca6cf into master Jun 19, 2017

@tamalsaha tamalsaha deleted the port branch Jun 19, 2017

@julianvmodesto

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2017

This works! But only when creating a new Ingress. Updating an existing Ingress with ingress.appscode.com/annotations-service: '{"service.beta.kubernetes.io/aws-load-balancer-ssl-cert": "..."}' doesn't seem to add port tcp-443.

@tamalsaha

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2017

Filed #267.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.