New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max-connections annotation #546
Conversation
test/framework/ingress_util.go
Outdated
@@ -21,6 +21,7 @@ import ( | |||
apiv1 "k8s.io/client-go/pkg/api/v1" | |||
apps "k8s.io/client-go/pkg/apis/apps/v1beta1" | |||
extensions "k8s.io/client-go/pkg/apis/extensions/v1beta1" | |||
"strconv" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run a ./hack/make.py
test/test-server/server.go
Outdated
@@ -27,6 +29,11 @@ type HttpServerHandler struct { | |||
} | |||
|
|||
func (h HttpServerHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
if delay, err := strconv.Atoi(r.URL.Query().Get("delay")); err == nil { | |||
fmt.Println("delay", delay) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove fmt.Print
test/test-server/server.go
Outdated
@@ -50,6 +57,11 @@ type HttpsServerHandler struct { | |||
} | |||
|
|||
func (h HttpsServerHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
if delay, err := strconv.Atoi(r.URL.Query().Get("delay")); err == nil { | |||
fmt.Println("delay", delay) | |||
time.Sleep(time.Second * time.Duration(delay)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strconv.Atoi
use time.ParseDuration()
that parse string to Duration, that could also support 10s
No description provided.