Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove is_active Field and rely on User.is_active #31

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Remove is_active Field and rely on User.is_active #31

merged 1 commit into from
Mar 3, 2022

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Mar 3, 2022 •
edited
Loading

Change description

Remove is_active Field and rely on User.is_active

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

#27

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@shadinaif shadinaif linked an issue Mar 3, 2022 that may be closed by this pull request
Remove the mapping._deprecated_field_is_active field from this package after production deployment #27
Open
@shadinaif shadinaif marked this pull request as draft March 3, 2022 11:58
@shadinaif shadinaif marked this pull request as ready for review March 3, 2022 12:10
OmarIthawi
OmarIthawi reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shadinaif. I have one quick change to avoid adding a migration.

The actual deletion should only be done after we fully migrate to this package:

tahoe_sites/models.py Show resolved Hide resolved
tahoe_sites/migrations/0004_remove_userorganizationmapping_is_active.py Show resolved Hide resolved
OmarIthawi
OmarIthawi approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @shadinaif for the quick update.

@OmarIthawi OmarIthawi removed a link to an issue Mar 3, 2022
Remove the mapping._deprecated_field_is_active field from this package after production deployment #27
Open
@shadinaif shadinaif merged commit a24b8d9 into main Mar 3, 2022
@shadinaif shadinaif deleted the shadinaif/remove_is_active branch March 3, 2022 12:32
@shadinaif shadinaif mentioned this pull request Mar 3, 2022
Merged
11 tasks
This was referenced Mar 3, 2022
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarIthawi OmarIthawi OmarIthawi approved these changes

@estherjsuh estherjsuh Awaiting requested review from estherjsuh

@melvinsoft melvinsoft Awaiting requested review from melvinsoft

@thraxil thraxil Awaiting requested review from thraxil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shadinaif @OmarIthawi