Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behaviour of get_organization_for_user #44

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Mar 8, 2022

Change description

Change behavior of get_organization_for_user . Switch the default value of fail_if_inactive from True to False

The reason is that edx-platform default behavior is not caring about the user being active or not. See get_single_user_organization method

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

(switch the default value of fail_if_inactive from True to False)
@shadinaif shadinaif force-pushed the shadinaif/switch-fail_if_inactive-default branch from 5e7ea3d to b67d7c4 Compare March 8, 2022 13:50
@shadinaif shadinaif merged commit 4a5fe0e into main Mar 8, 2022
@shadinaif shadinaif deleted the shadinaif/switch-fail_if_inactive-default branch March 8, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants