Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New APIs for LMS #48

Merged
merged 1 commit into from
Mar 23, 2022
Merged

New APIs for LMS #48

merged 1 commit into from
Mar 23, 2022

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Mar 23, 2022

Change description

New APIs for LMS

def get_organization_user_by_email(email, organization, fail_if_inactive=False):
def is_exist_organization_user_by_email(email, organization, must_be_active=False):
def deprecated_get_admin_users_queryset_by_email(email):

Update: deprecated_get_admin_users_queryset_by_email is named get_admin_users_queryset_by_email in this PR. Fixed here

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Copy link
Contributor

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename the function, otherwise it looks great

tahoe_sites/tests/test_api.py Outdated Show resolved Hide resolved
tahoe_sites/api.py Show resolved Hide resolved
@shadinaif shadinaif merged commit 9f59cef into main Mar 23, 2022
@shadinaif shadinaif deleted the shadinaif/new_apis_for_lms branch March 23, 2022 21:42
@shadinaif shadinaif mentioned this pull request Mar 24, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants