Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get configuration up to speed with the Ruby integration #49

Closed
jeffkreeftmeijer opened this issue Dec 13, 2016 · 4 comments
Closed

Get configuration up to speed with the Ruby integration #49

jeffkreeftmeijer opened this issue Dec 13, 2016 · 4 comments
Assignees
Milestone

Comments

@jeffkreeftmeijer
Copy link
Member

http://docs.appsignal.com/ruby/configuration/

@jeffkreeftmeijer
Copy link
Member Author

jeffkreeftmeijer commented Jan 25, 2017

I've compared the Elixir configuration options to the ones in Ruby, and these are my findings. @thijsc, @tombruijn am I correct that all options under the "Not implemented"-header should also be implemented for the Elixir integration? If so, I'll add issues for them before closing this.

Not implemented

  • :ca_file_path
  • :enable_allocation_tracking
  • :enable_frontend_error_reporting
  • :enable_gc_instrumentation
  • :hostname

Ruby specific

  • :instrument_net_http
  • :instrument_redis
  • :instrument_sequel

Implemented differently from the Ruby integration

@tombruijn
Copy link
Member

  • :ca_file_path
    • We should be able to set this. In the Ruby gem we ship our own ca file but I don't find one in the Elixir package. If the user has SSL connection issues setting this to the host's ca path usually helps.
  • :enable_allocation_tracking & :enable_gc_instrumentation
    • If we can monitor this in Elixir we should
  • :enable_frontend_error_reporting
    • Since this only works in combination with the Ruby gem currently and our next version should not rely on a gem/elixir package on the user's server I don't think this is necessary
  • :hostname
    • yes

@jeffkreeftmeijer
Copy link
Member Author

jeffkreeftmeijer commented Jan 25, 2017

I creates issues for :ca_file_path (#97), :hostname (#98) and a general one about allocation tracking and GC instrumentation, for future reference (#99). #98 is in the 1.0 milestone, the other two aren't. Closing this as we'll pick up the config changes in their respective issues.

@tombruijn
Copy link
Member

Why not make #97 part of the 1.0 release as well?
Small change to pass it to the agent as an env var. I'm just not sure how much work it would be to pass it to a HTTP lib (if at all possible) like HTTPoison added in #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants