Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect the :env from Mix.env #91

Closed
jeffkreeftmeijer opened this issue Jan 25, 2017 · 2 comments
Closed

Detect the :env from Mix.env #91

jeffkreeftmeijer opened this issue Jan 25, 2017 · 2 comments
Milestone

Comments

@jeffkreeftmeijer
Copy link
Member

Extracted from #86:

Sidenote: Can't we detect the env from Mix.env ? So it's not necessary to set?

In the Ruby integration, we automatically detect the env from Rails, Padrino and Sinatra applications. For Elixir applications, we can default to the Mix.env.

WDYT @thijsc, @tombruijn?

Related: #49.

@arjan
Copy link
Contributor

arjan commented Jan 25, 2017

I've already researched this a few months back, and this is not possible, Mix.env is not available at runtime.

And when compiling a dependent library (like Appsignal itself) from another project, Mix.env is always :prod, so the Appsignal code (e.g. config.ex cannot really use Mix.env at its compiletime to set the default env.

@jeffkreeftmeijer
Copy link
Member Author

Thanks, I'll close this one, then. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants