Elixir parameter filtering does not match Phoenix's behavior #936
Assignees
Labels
Comments
tombruijn
added a commit
that referenced
this issue
Apr 25, 2024
The Phoenix Logger filters out partial keys matches. Our implementation for Phoenix's filter_parameters did not follow this implementation. This change adds support for filtering out partial key matches when using the discard filtering strategy. Phoenix implementation: https://github.com/phoenixframework/phoenix/blob/dfb0c00d2077e10f8df6cc6e334e04924c4c2bcd/lib/phoenix/logger.ex#L157-L199 Fixes #936
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In Phoenix, if you have a param filter for
passwordit will filter any parameter value where the key contains the stringpassword(e.g. includinguser-password).The behavior of our own parameter filtering only filters the value if the key exactly matches the key to filter. (e.g.
passwordis filtered, butuser-passwordis not).Ideally the behavior is the same as Phoenix's behavior.
Intercom: https://app.intercom.com/a/inbox/yzor8gyw/inbox/shared/unassigned/conversation/16410700311389?view=List
The text was updated successfully, but these errors were encountered: