Filter structs in MapFilter #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkreeftmeijer
force-pushed
the
struct-filtering
branch
from
c7de233
to
883dd99
Compare
jvanbaarsen
approved these changes
Sep 25, 2019
|
@jeffkreeftmeijer good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MapFilteris used to filter parameters and session data before sending it to AppSignal. Currently, it filters nested maps and lists. Structs aren't generally found in parameter maps, unless a plug adds them when parsing the parameters. We've seen this in the open_api_spex library, where it's not an issue as the extracted parameter struct isn't actually added to the params map.However, since it makes sense to properly filter structs if they end up in the parameters, this patch adds struct filtering by converting both maps and stucts to lists, and then filtering those.
It also includes a general cleanup in the tests for
MapFilter, which is contained in c7de233 and includes no structural changes.