Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config cleanup #55

Merged
merged 18 commits into from Jan 10, 2017
Merged

Config cleanup #55

merged 18 commits into from Jan 10, 2017

Conversation

jeffkreeftmeijer
Copy link
Member

  • Adds tests for all supported configuration options in both the application and system environments
  • Adds tests to make all configuration options are written to the system env
  • Fix: Set APPSIGNAL_FILTER_PARAMETERS from application env
  • Fix: Set APPSIGNAL_SEND_PARAMS from application env
  • Fix: Set :ignore_actions from system env
  • Fix: Set :ignore_errors from system env
  • Fix: Set :log from system env
  • Fix: Set :log_path from system env
  • Fix: Set :running_in_container automatically on Heroku without overwriting values from the application and system environments

@jeffkreeftmeijer jeffkreeftmeijer mentioned this pull request Dec 16, 2016
Merged
@jeffkreeftmeijer
Clear the ENV in the setup in appsignal_config_test
7953de6
@jeffkreeftmeijer
Test default and valid configurations
116ca80
@jeffkreeftmeijer
Split up the application environment config tests
3fd9226
@jeffkreeftmeijer
Remove Heroku DYNO check, add test for :running_in_container
6ab8006
@jeffkreeftmeijer
Clean up minimum configuration tests
11b3cd8
@jeffkreeftmeijer
Add tests to make sure the System env gets set from the application env
a3c5646
@jeffkreeftmeijer
Set APPSIGNAL_FILTER_PARAMETERS from application env
8856753
@jeffkreeftmeijer
Set APPSIGNAL_SEND_PARAMS from application env
ce6cba3
@jeffkreeftmeijer
Add tests to make sure the application env gets set from the System env
1df6c16
@jeffkreeftmeijer
Set :ignore_actions from system env
8732089
@jeffkreeftmeijer
Set :ignore_errors from system env
ad7d3a0
@jeffkreeftmeijer
Set :log from system env
94360a1
@jeffkreeftmeijer
Set :log_path from system env
0be747a
@jeffkreeftmeijer
Remove duplicate config tests
625b99e
@jeffkreeftmeijer
Clean up the setup block in the config tests
03ce769
@jeffkreeftmeijer
Add a test to make sure the system environment overwrites the applica…
942e3db 
…tion environment configuration
@jeffkreeftmeijer
:running_in_container gets set automatically on Heroku
54ddfd2
@jeffkreeftmeijer
Clear APPSIGNAL_FILTER_PARAMETERS in filter_test.exs
7d6dde2 
Since 4fb068, APPSIGNAL_FILTER_PARAMETERS gets set from
Appsignal.write_to_environment/1. This commit clears it in
filter_test.exs, so it doesn't get set into the application config in
the next test.
@jeffkreeftmeijer jeffkreeftmeijer mentioned this pull request Jan 10, 2017
Closed
@arjan arjan merged commit 78ab765 into master Jan 10, 2017
@tombruijn tombruijn deleted the config branch January 14, 2017 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjan arjan Awaiting requested review from arjan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffkreeftmeijer @arjan